Compass 3.0.0#33
Merged
Merged
Conversation
|
@vadymmarkov, thanks for your PR! By analyzing the annotation information on this pull request, we identified @zenangst, @jessearmand and @onmyway133 to be potential reviewers |
Contributor
|
I agree with those ideas. I have removed Sugar as a dependency as well in my own fork. |
| s.ios.source_files = 'Sources/{iOS,Shared}/**/*' | ||
| s.osx.source_files = 'Sources/{Mac,Shared}/**/*' | ||
| s.dependency 'Sugar' | ||
| s.ios.source_files = 'Sources/**/*' |
Contributor
There was a problem hiding this comment.
I think we can reduce to just s.source_files
Contributor
Author
|
Well, seems like it's gonna be v3 because the last released is v2. We just had a wrong one in Podspec. |
Contributor
|
🎸 🎶 🎶 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

@zenangst @RamonGilabert @onmyway133
We kinda like to break
Compassfrom time to time, so it's a brand new breaking change 😄Compass.parsecompletion closure in favour ofLocationstruct:So instead of:
We unwrap optional
Location:The advantage of this approach is that
Compass.parseis not async anymore, we get the needed result straight away and can handle the case whenurncould not be parsed.RouterandRoutableto support Mac by using type aliases.Locationstruct. Makes it easier to add more properties in the future.Stringmethods fromSugarand I feel like it's unnecessary to hold this dependency, especially thinking about Swift 3 where it's no longer actual. So... we don't useSugarinCompassanymore 😄